Html escaping #175
Merged
Html escaping #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Backbone example in master is old. Can you apply it to the one in the Backbone branch instead? |
|
Hi, the html_escaping branch I created was actually based off of the backbone branch. I'm still quite new to the whole github thing but as far as I can tell my pull request is asking to merge back into the backbone branch as well. If I'm mistaken about something, please let me know. Thanks! |
|
Oh, sorry, I must have assumed it weren't or something. |
sindresorhus
added a commit
that referenced
this pull request
Jun 3, 2012
Html escaping of Backbone underscore template
Merged
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
Html escaping of Backbone underscore template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update to the underscore library we can now make use of html escaping in the underscore templates. This fixes the case where e.g. you could enter script tags as a todo and it have it execute, or enter italic tags and get italics displayed.