New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React with ES6 and Webpack Implementation #1813
React with ES6 and Webpack Implementation #1813
Conversation
@acamposruiz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sindresorhus and @passy to be potential reviewers. |
Hi @dhruvdutt , I have cleaned up my commit messages and rebasen as you asked in this new branch and Pull Request |
Cool. Are there still issues with jshint in |
Appears that way so I will check all that and fix it as soon as I can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to migrate todoModel.js to ES6.
Maintain indentations consistency across all files. (preferably 4 spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why added node_modules?
I do not know if it is made a npm install on server on every project in order to let the example work out, do you know? |
I have that doubt because of node_modules folder is not included in .gitignore in other examples, why? |
Hi @dhruvdutt , Do you know anything about this error on travis? |
Okay, the other examples have node_modules folder which includes the final dist only and not the src. I believe this must have been done to directly serve package assets through GitHub static hosting. Not sure about travis-ci check. Some nested dep seems to cause the issue. |
I've already removed almost all node_modules, only todomvc dependences will remains there. But travis-ci issue keep stay there and it seems like it has been happening for a while, so many others contributions remains unmerge because of this. I really do not know how to deal with this but I will keep digging some days. :) |
@acamposruiz Are you still intrested in landing this ? |
@FadySamirSadek yeah I'm still interested ;), Do you want me to do anything? what's next? |
|
Please refer to #2219 |
Hi!
Here I have develop an aproach with React 0.14 and webpack with ES6, I think can be a good thing present a way to modularize this project with webpack.
The project is in examples/react-webpack-es6.
Thanks for suggestions!
Antonio