Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backbone.Marionette implementations #284

Closed
wants to merge 34 commits into from

Conversation

mxriverlynn
Copy link
Contributor

per @addyosmani's request, this pull request is to include the Backbone.Marionette architecture examples. It includes both the non-AMD (simple) and non-AMD (Marionette modules) versions of TodoMVC that are referenced in the Backbone Fundamentals chapter on Marionette as I based the Marionette modules version off the non-module version.

The two different versions are in separate folders, sitting next to each other. If you wish to exclude the simple one, it should be easy enough to remove that one folder.

Let me know if anything else needs to be done for this, or if you want me to exclude that folder, etc.

@@ -1 +0,0 @@
todomvc.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont remove this

@addyosmani
Copy link
Member

@sindresorhus I'd like us to merge this initial version into labs, but create a new issue linked to your comments so the app can be reworked to match specs at a later point. With the Thorax app already landed and a Chaplin one inbound soon, I'd love to get Marionette in there too.

@derickbailey could you revert the change to the CNAME file? If you think you'll be short on time I can do that when I merge. Cheers!

@sindresorhus
Copy link
Member

@addyosmani @derickbailey Landed :)

I've created an issue with the remaining issues in #294

Thanks for this awesome contribution!

@addyosmani
Copy link
Member

Thanks Sindre and Derick!

Fwiw, I've decided to drop the non-Marionette module version of the application in favour of just using Derick's module variant. I've added links to both the app index and a readme which informs users where they can find the RequireJS and non-Marionette module version of the app.

I figure where possible we should be making it as simple as possible to compare labs apps and the variations are still available outside the project.

gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this pull request Dec 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants