dart: Escape HTML in todo rendering #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM... Thanks ! |
|
Note : we do not systematically update the compiled JS. It would probably be relevant this time (WDYT ? I can provide the compiled JS). I'll update the README about this. |
|
Oh, I just pushed the compile JavaScript. An update to the README about this would probably be nice nonetheless. |
sindresorhus
added a commit
that referenced
this pull request
Jan 17, 2013
dart: Escape HTML in todo rendering
|
@MathieuLorber do you know why the ouput completely changes on each compile? |
|
The Dart compilation produces a all-in-one file, I assume its output embeds all the framework evolutions between our updates... |
gustaff-weldon
pushed a commit
to gustaff-weldon/todomvc
that referenced
this pull request
Dec 23, 2013
dart: Escape HTML in todo rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the implementation from the experimental branch. I guess at some point in the future we can use the library function.
@MathieuLorber Could you take a quick look if this is okay?
(ref #397)