dart: Escape HTML in todo rendering #398

Merged
merged 2 commits into from Jan 17, 2013

Conversation

Projects
None yet
3 participants
@passy
Member

passy commented Jan 16, 2013

I took the implementation from the experimental branch. I guess at some point in the future we can use the library function.

@MathieuLorber Could you take a quick look if this is okay?

(ref #397)

@MathieuLorber

This comment has been minimized.

Show comment Hide comment
@MathieuLorber

MathieuLorber Jan 17, 2013

Contributor

LGTM... Thanks !

Contributor

MathieuLorber commented Jan 17, 2013

LGTM... Thanks !

@MathieuLorber

This comment has been minimized.

Show comment Hide comment
@MathieuLorber

MathieuLorber Jan 17, 2013

Contributor

Note : we do not systematically update the compiled JS. It would probably be relevant this time (WDYT ? I can provide the compiled JS).

I'll update the README about this.

Contributor

MathieuLorber commented Jan 17, 2013

Note : we do not systematically update the compiled JS. It would probably be relevant this time (WDYT ? I can provide the compiled JS).

I'll update the README about this.

@passy

This comment has been minimized.

Show comment Hide comment
@passy

passy Jan 17, 2013

Member

Oh, I just pushed the compile JavaScript. An update to the README about this would probably be nice nonetheless.

Member

passy commented Jan 17, 2013

Oh, I just pushed the compile JavaScript. An update to the README about this would probably be nice nonetheless.

sindresorhus added a commit that referenced this pull request Jan 17, 2013

Merge pull request #398 from passy/dart-escaping
dart: Escape HTML in todo rendering

@sindresorhus sindresorhus merged commit 1448954 into tastejs:gh-pages Jan 17, 2013

@sindresorhus

This comment has been minimized.

Show comment Hide comment
@sindresorhus

sindresorhus Jan 17, 2013

Member

@MathieuLorber do you know why the ouput completely changes on each compile?

Member

sindresorhus commented Jan 17, 2013

@MathieuLorber do you know why the ouput completely changes on each compile?

@MathieuLorber

This comment has been minimized.

Show comment Hide comment
@MathieuLorber

MathieuLorber Jan 17, 2013

Contributor

The Dart compilation produces a all-in-one file, I assume its output embeds all the framework evolutions between our updates...

Contributor

MathieuLorber commented Jan 17, 2013

The Dart compilation produces a all-in-one file, I assume its output embeds all the framework evolutions between our updates...

gustaff-weldon pushed a commit to gustaff-weldon/todomvc that referenced this pull request Dec 23, 2013

Merge pull request #398 from passy/dart-escaping
dart: Escape HTML in todo rendering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment