Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added YUI library to the repo #794

Merged
merged 1 commit into from Jan 24, 2014

Conversation

ColinEberhardt
Copy link
Member

Fixes #792

The tests now run for this app :-)

ITs-MacBook-Air:browser-tests ceberhardt$ mocha allTests.js -R spec --framework=yui

TodoMVC - yui (1/1)
No Todos
  ✓ should hide #main and #footer (199ms)
New Todo
  ✓ should allow me to add todo items (579ms)
  ✓ should clear text input field when an item is added (316ms)
  ✓ should trim text input (563ms)
  ✓ should show #main and #footer when items added (409ms)
Mark all as completed
  ✓ should allow me to mark all items as completed (1091ms)
  ✓ should allow me to clear the completion state of all items (1055ms)
  ✓ complete all checkbox should update state when items are completed / cleared (1283ms)
Item
  ✓ should allow me to mark items as complete (916ms)
  ✓ should allow me to un-mark items as complete (861ms)
  ✓ should allow me to edit an item (1155ms)
  ✓ should show the remove button on hover 
Editing
  ✓ should hide other controls when editing (705ms)
  ✓ should save edits on enter (1155ms)
  ✓ should save edits on blur (1214ms)
  ✓ should trim entered text (1124ms)
  ✓ should remove the item if an empty text string was entered (1053ms)
  1) should cancel edits on escape
Counter
  ✓ should display the current number of todo items (499ms)
Clear completed button
  ✓ should display the number of completed items (978ms)
  ✓ should remove completed items when clicked (871ms)
  ✓ should be hidden when there are no items that are completed (922ms)
Persistence
  ✓ should persist its data (2367ms)
Routing
  ✓ should allow me to display active items (922ms)
  ✓ should allow me to display completed items (859ms)
  ✓ should allow me to display all items (1200ms)
  ✓ should highlight the currently applied filter (1081ms)


26 passing (2m)
1 failing

@addyosmani
Copy link
Member

LGTM. Thanks Colin!

addyosmani added a commit that referenced this pull request Jan 24, 2014
@addyosmani addyosmani merged commit c5c1a78 into tastejs:gh-pages Jan 24, 2014
sindresorhus added a commit that referenced this pull request Jan 26, 2014
@clarle
Copy link
Contributor

clarle commented Jan 28, 2014

@ColinEberhardt @sindresorhus It looks like this recent change lead to some issues with the YUI TodoMVC.

I'll take a look to see if the problem is with 3.14.1 or if the wrong lib was used. Thanks!

@ColinEberhardt
Copy link
Member Author

Yes, it looks like routing is currently broken with YUI - see the following test report:

․ TodoMVC - yui No Todos should hide #main and #footer: 206ms
․ TodoMVC - yui New Todo should allow me to add todo items: 583ms
․ TodoMVC - yui New Todo should clear text input field when an item is added: 335ms
․ TodoMVC - yui New Todo should trim text input: 330ms
․ TodoMVC - yui New Todo should show #main and #footer when items added: 417ms
․ TodoMVC - yui Mark all as completed should allow me to mark all items as completed: 925ms
․ TodoMVC - yui Mark all as completed should allow me to clear the completion state of all items: 1064ms
․ TodoMVC - yui Mark all as completed complete all checkbox should update state when items are completed / cleared: 1443ms
․ TodoMVC - yui Item should allow me to mark items as complete: 1030ms
․ TodoMVC - yui Item should allow me to un-mark items as complete: 875ms
․ TodoMVC - yui Item should allow me to edit an item: 1148ms
․ TodoMVC - yui Item should show the remove button on hover: 11ms
․ TodoMVC - yui Editing should hide other controls when editing: 829ms
․ TodoMVC - yui Editing should save edits on enter: 1202ms
․ TodoMVC - yui Editing should save edits on blur: 1255ms
․ TodoMVC - yui Editing should trim entered text: 1178ms
․ TodoMVC - yui Editing should remove the item if an empty text string was entered: 1060ms
1) TodoMVC - yui Editing should cancel edits on escape
․ TodoMVC - yui Counter should display the current number of todo items: 483ms
․ TodoMVC - yui Clear completed button should display the number of completed items: 929ms
․ TodoMVC - yui Clear completed button should remove completed items when clicked: 915ms
․ TodoMVC - yui Clear completed button should be hidden when there are no items that are completed: 918ms
2) TodoMVC - yui Persistence should persist its data
3) TodoMVC - yui Routing should allow me to display active items
4) TodoMVC - yui Routing should allow me to display completed items
․ TodoMVC - yui Routing should allow me to display all items: 1372ms
5) TodoMVC - yui Routing should highlight the currently applied filter

22 passing (2m)
5 failing

The failure was introduced in a commit after this PR. Running the automated UI tests against this commit 9429daa#diff-0c20f82b7a1736c1c92b06b0123ca8cc shows that routing is working, however it looks like there other failures:

․ TodoMVC - yui No Todos should hide #main and #footer: 195ms
․ TodoMVC - yui New Todo should allow me to add todo items: 669ms
․ TodoMVC - yui New Todo should clear text input field when an item is added: 339ms
․ TodoMVC - yui New Todo should trim text input: 413ms
․ TodoMVC - yui New Todo should show #main and #footer when items added: 734ms
․ TodoMVC - yui Mark all as completed should allow me to mark all items as completed: 918ms
․ TodoMVC - yui Mark all as completed should allow me to clear the completion state of all items: 1051ms
․ TodoMVC - yui Mark all as completed complete all checkbox should update state when items are completed / cleared: 1345ms
․ TodoMVC - yui Item should allow me to mark items as complete: 887ms
1) TodoMVC - yui Item should allow me to un-mark items as complete
․ TodoMVC - yui Item should allow me to edit an item: 1162ms
․ TodoMVC - yui Item should show the remove button on hover: 10ms
․ TodoMVC - yui Editing should hide other controls when editing: 787ms
․ TodoMVC - yui Editing should save edits on enter: 1342ms
․ TodoMVC - yui Editing should save edits on blur: 1192ms
․ TodoMVC - yui Editing should trim entered text: 1269ms
․ TodoMVC - yui Editing should remove the item if an empty text string was entered: 1074ms
2) TodoMVC - yui Editing should cancel edits on escape
․ TodoMVC - yui Counter should display the current number of todo items: 513ms
․ TodoMVC - yui Clear completed button should display the number of completed items: 918ms
․ TodoMVC - yui Clear completed button should remove completed items when clicked: 873ms
․ TodoMVC - yui Clear completed button should be hidden when there are no items that are completed: 968ms
․ TodoMVC - yui Persistence should persist its data: 2500ms
․ TodoMVC - yui Routing should allow me to display active items: 903ms
․ TodoMVC - yui Routing should allow me to display completed items: 1043ms
․ TodoMVC - yui Routing should allow me to display all items: 1233ms
․ TodoMVC - yui Routing should highlight the currently applied filter: 1043ms

25 passing (2m)
2 failing

@clarle
Copy link
Contributor

clarle commented Jan 29, 2014

@ColinEberhardt It looks like it might be a bug in the latest version of the ModelSync.Local module. I'll have a fix for it as soon as I can.

@ColinEberhardt ColinEberhardt deleted the yui-add-library branch February 4, 2014 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants