Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of warning #54

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Get rid of warning #54

merged 4 commits into from
Sep 2, 2022

Conversation

jzwar
Copy link
Collaborator

@jzwar jzwar commented Sep 1, 2022 •
edited
Loading

Minor Code Clean-up

This is to deal with issue #43 .

  1. There were many warnings when building splinepy, that made the project look very unprofessional. Most of the warnings were related to comparisons between signed and unsigned types.
  2. There were a class member variables used as counters that were very unspecific, called i and j, which is problematic as it is unclear what the counters are actually referring to.
  • clang-format applied
  • unit tests for new feature (not applicable)

@jzwar
Get Rid of compiler warnings and replaced counters
c859cb0 
there were some class member variables used as counters, which is a very risky undertaking. So I got rid of it.

No more compiler warnings, just the onces thrown by external libraries
@jzwar
Applied formatting
4856538
@jzwar jzwar added the small Small Modifications required (<1h) label Sep 1, 2022
@jzwar jzwar requested a review from j042 September 1, 2022 09:34
j042
j042 reviewed Sep 1, 2022
View reviewed changes
cpp/splinepy/utils/arrays.hpp Outdated Show resolved Hide resolved
@j042
Copy link
Member

j042 commented Sep 1, 2022

Also, once napf's PR merges, could you update the commit?

@j042
Copy link
Member

j042 commented Sep 2, 2022

just one more thing, could you please keep counter as i, j, k, l?

j042
j042 approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@j042 j042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

cpp/splinepy/py/py_bspline.hpp Show resolved Hide resolved
@j042 j042 merged commit d2195f4 into main Sep 2, 2022
@j042 j042 deleted the bf-get-rid-of-warnings branch September 2, 2022 11:18
@j042 j042 mentioned this pull request Sep 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j042 j042 j042 approved these changes

Assignees
No one assigned
Labels
small Small Modifications required (<1h)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jzwar @j042