-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic spline core #62
Conversation
minir fix in CurrentProperties of bezier
only new core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this is a very shallow review (I am sorry), this looks very impressive. Love the tracked array functionality and also how much effort you gave to unify the interfaces <3
Very nice work!!!
LGTM
fix cast
Co-authored-by: jzwar <63095162+jzwar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addressed issues
Description
Instead of making every single classes available, we define a template-free base spline type. Then, we inherit from both base and third party splines. Can dynamically create third party splines, but return, for example, a shared pointer of the base spline. Here, at base spline, we've defined scalar raw-ptr based operations. That way it is compatible with anything.
Frontend changes
Changes
Up next