Fix font-size calculation if font-family's differ #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the original DOM element and the copy DOM element have very different font-family's, this calculation could be way off, and generate a very big overlay. By using the copy's width and height we do the calculation with the final font-family and assure that its always good.
|
Good pickup. Thanks for the patch! |
tatey
added a commit
that referenced
this pull request
Oct 6, 2011
Fix font-size calculation if font-family's differ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the original DOM element and the copy DOM element have very different
font-family's, this calculation could be way off, and generate a very big
overlay.
By using the copy's width and height we do the calculation with
the final font-family and assure that its always good.