Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys displayed in help change order on reload #133

Closed
DavidSpickett opened this issue Jul 29, 2020 · 1 comment · Fixed by #134
Closed

Keys displayed in help change order on reload #133

DavidSpickett opened this issue Jul 29, 2020 · 1 comment · Fixed by #134

Comments

@DavidSpickett
Copy link
Contributor

If I reload/reopen the help page (H) in w3m the order of the assigned keys changes each time. As does the displayed upper case name on the end of the lines. (if it has multiple names)

+,C-v,SPC,^[[6~      Scroll down one page (NEXT_PAGE)
ESC-s                Save document source (DOWNLOAD)

In the first line the left column will re-order itself on reload, the second line switches from DOWNLOAD to SAVE. (use R to refresh and keep the same position on the page)

This is because the CGI script to display these is iterating over hashes which aren't ordered. (as far as I can tell, I'm new to perl)

I have a patch that fixes this. Is a pull request the way to contribute?

@tats
Copy link
Owner

tats commented Jul 30, 2020

I have a patch that fixes this. Is a pull request the way to contribute?

Yes, please make a pull request to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants