New commands for moving cursor on screen #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, and updated doc-jp/README.func. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new commands CURSOR_TOP, CURSOR_MIDDLE and CURSOR_BOTTOM replicate vi's movements invoked by H, M and L. That is, CURSOR_TOP moves the cursor to the first currently visible line of the file, CURSOR_MIDDLE to the middle, and CURSOR_BOTTOM to the last visible line.
Since H, M and L are already bound to commands in w3m, I did not bind CURSOR_* to any keys by default, so they need to be added to ~/.w3m/keymap like MOVE_RIGHT1 etc.
Also, I'm not sure how successful my efforts in trying to add the new commands to the documentation were. I added them to a bunch of places and the help menu shows them so I think it worked? Either way, I don't speak Japanese, so that part of it is certainly missing. And MANUAL.html only seems to contain commands with default keybindings, so I didn't add them there either.