Fix gopher support #152
Merged
Fix gopher support #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, now that it kind of works, wouldn't it make sense to enable gopher support by default? |
|
Merged, thanks for your contribution. Also, I'll enable Gopher support by default soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, gopher was completely broken. While this isn't a perfect fix, it works far better on sites I've tested (far better=actually loads most of them).
A slight change is that I moved the filetype indicator character to the end of URLs for convenience; as far as I can tell, this shouldn't cause problems, but it might be better to move it back later (EDIT: looks like it did cause problems after all, so I moved it back in the third commit). Other than that, I only added the 'i' non-link line type.