Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved inline image protocol support #161

Merged
merged 7 commits into from
Feb 6, 2021
Merged

Improved inline image protocol support #161

merged 7 commits into from
Feb 6, 2021

Conversation

bptato
Copy link
Contributor

@bptato bptato commented Feb 2, 2021

  • mlterm and sixel image support is no longer hidden behind undocumented flags, instead they can be selected in the options menu. Note: I left in the -sixel and -ri flags for backward-compatibility, but I'm unsure if they're actually worth keeping since they were undocumented and really should've been config options in the first place. So feel free to remove them, I guess.
  • There were two unlink calls that broke image caching and required downloading images with mlterm or img2sixel... which is kind of a disaster IMO as these obviously won't respect w3m proxy settings. So for now I've disabled these unlinks, further investigation is needed to figure out if and when they should be called.
  • Support for iTerm2 image protocol is now available; tested with a WIP(?) development build of alacritty which supports sixels and iTerm2 images (and fails very rudely when I try to feed it svg files + won't play gif animations, unfortunately...).
  • For iTerm2 I also added a base64_encode function in which unlike encodeB can also encode arbitrary char sequences with null bytes (i.e. images). It should also be somewhat faster than encodeB so I fully replaced that function with this new one.

@tats tats merged commit e66ca9f into tats:master Feb 6, 2021
@tats
Copy link
Owner

tats commented Feb 6, 2021

Merged, and updated option setting strings.
Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants