Fix all reported warnings when -Wall is enabled and enable -Wall by default. While there, move OPTS to end of CFLAGS. This allows the user to override default options. #222

rkta · 2022-02-20T11:14:17Z

No description provided.

This allows the user to override default options.

While there, add some comments to better understand the code flow in localcgi_post().

This change removes all warnings (-Wall) from this function.

Throughout the whole code base only char * is passed, but a unsigned char * is expected. This leads to several warnings. Fix the interface and cast to unsigned char * internally to avoid any changes to the behaviour.

When compiling with -Wformat-overflow=2 GCC reports: note: 'sprintf' output between 16 and 35 bytes into a destination of size 32

This removes a warning with -Wall.

tats · 2022-04-09T10:33:07Z

Merged, thanks for your contribution.

rkta added 17 commits February 20, 2022 11:14

Move OPTS to end of CFLAGS

f7601b4

This allows the user to override default options.

Suppress two warnings when compiling with tcc

8929550

While there, add some comments to better understand the code flow in localcgi_post().

Use standard conforming main() definition

84f724a

Use main(void) when not taking arguments

dad5cbe

Remove unused variable

916104b

Fix warning for unused variable without USE_M17N

4901408

Fix warning for unused variable w/o MENU_SELECT

ab22479

Take the correct char type in growbuf_append()

0cd26b9

This change removes all warnings (-Wall) from this function.

Let strncpy write the null terminator

b25abc5

Explicitly cast to unsigned when passing to MD5()

561f27f

Let base64_encode() take a char *

cf7058b

Throughout the whole code base only char * is passed, but a unsigned char * is expected. This leads to several warnings. Fix the interface and cast to unsigned char * internally to avoid any changes to the behaviour.

Fix a potential buffer overflow

c5c63a1

When compiling with -Wformat-overflow=2 GCC reports: note: 'sprintf' output between 16 and 35 bytes into a destination of size 32

Initialize struct before use

d3ea4b3

Use cast to suppress warning

cf2fd62

Use unsigned int for image size

0073ec6

This removes a warning with -Wall.

Enable -Wall by default

bf40283

Cast away a warning under OpenBSD 7.0

5b33d9f

N-R-K mentioned this pull request Mar 6, 2022

[RFC] fix -Wdiscarded-qualifiers warning #216

Closed

tats merged commit ca9f5fc into tats:master Apr 9, 2022

rkta deleted the Wall branch May 1, 2022 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix all reported warnings when -Wall is enabled and enable -Wall by default. While there, move OPTS to end of CFLAGS. This allows the user to override default options. #222

Fix all reported warnings when -Wall is enabled and enable -Wall by default. While there, move OPTS to end of CFLAGS. This allows the user to override default options. #222

rkta commented Feb 20, 2022

tats commented Apr 9, 2022

Fix all reported warnings when -Wall is enabled and enable -Wall by default. While there, move OPTS to end of CFLAGS. This allows the user to override default options. #222

Fix all reported warnings when -Wall is enabled and enable -Wall by default. While there, move OPTS to end of CFLAGS. This allows the user to override default options. #222

Conversation

rkta commented Feb 20, 2022

tats commented Apr 9, 2022