Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tellStatus provide info on progress of Check Integrity #561

Closed
kkartaltepe opened this issue Feb 6, 2016 · 3 comments
Closed

tellStatus provide info on progress of Check Integrity #561

kkartaltepe opened this issue Feb 6, 2016 · 3 comments
Labels
enhancement

Comments

@kkartaltepe
Copy link
Contributor

When aria2 is hashing some larger files it can take a noticeable amount of time to hash. In the aria2c interface you can see the percentage of progress of the hash check. It would be nice to have this information in the tellStatus or some where else accessible via the RPC interface.

I'm not sure if this should be presented as a % or # of pieces checked or something else. What ever you feel is appropriate.
@tatsuhiro-t
Copy link
Collaborator

This is interesting suggestion. Showing progress definitely improves UX.

@kkartaltepe
Copy link
Contributor Author

So I kind of ripped the aria2 command line status report of hashing progress and added it to the tellStatus Rpc call in
https://github.com/kkartaltepe/aria2/tree/RpcTellStatus-Hashing

I wanted to know if you would be willing to accept a pull request for this issue and your thoughts on how current progress of hashing should be reported.
This branch was just a simple proof of concept that it could be reported as part of the RPC interface (and for me to brush up on my C++ while learning the aria2 code base).

@tatsuhiro-t
Copy link
Collaborator

It is very interesting. We would happily accept a patch.

kkartaltepe added a commit to kkartaltepe/aria2 that referenced this issue Mar 18, 2016
@kkartaltepe
Report hashLength in tellStatus
eec0023 
Allows RPC clients to view progress of the currently hashing
RequestGroup if they query it's status.
Closes aria2#561
kkartaltepe added a commit to kkartaltepe/aria2 that referenced this issue Mar 18, 2016
@kkartaltepe
Report verifiedLength in tellStatus
fb423f8 
Allows RPC clients to view the progress of the verify integrity step
of downloading.

Closes aria2#561
kkartaltepe added a commit to kkartaltepe/aria2 that referenced this issue Mar 18, 2016
@kkartaltepe
Report verifiedLength in tellStatus
04fecc6 
Allows RPC clients to view the progress of the verify integrity step
of downloading.

Closes aria2#561
kkartaltepe added a commit to kkartaltepe/aria2 that referenced this issue Mar 18, 2016
@kkartaltepe
Report verifiedLength in tellStatus
3516674 
Allows RPC clients to view the progress of the verify integrity step
of downloading.

Closes aria2#561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tatsuhiro-t @kkartaltepe