-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bun を追加 #434
ci: bun を追加 #434
Conversation
ウォークスルーこの変更概要では、「.gitignore」に「node_modules」を追加して無視するようにしたり、ツール「bun」や「ruby」のバージョンを更新したり、コミットメッセージのリント設定を導入する新しいファイルを追加しています。さらに、新しいスクリプトを実行するフックやインストールチェックを追加し、プロジェクトの設定を改善しました。 変更点
シーケンス図この変更には新機能や制御フローの修正が含まれていないため、シーケンス図の生成は今回は不要です。 リンクされた問題に対する評価
詩
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
bun.lockb
is excluded by!**/bun.lockb
Files selected for processing (6)
- .gitignore (1 hunks)
- .tool-versions (1 hunks)
- commitlint.config.cjs (1 hunks)
- lefthook.yml (1 hunks)
- package.json (1 hunks)
- tool/bootstrap.sh (1 hunks)
Files skipped from review due to trivial changes (5)
- .gitignore
- .tool-versions
- commitlint.config.cjs
- lefthook.yml
- package.json
############################################################################## | ||
## | ||
## lefthook | ||
## | ||
############################################################################## | ||
echo "" | ||
echo "🚀 lefthook install: Start" | ||
if type lefthook >/dev/null 2>&1; then | ||
if lefthook install; then | ||
echo "✅ lefthook install: Success" | ||
else | ||
echo "🚫 lefthook install: Failed" | ||
fi | ||
else | ||
echo "⚠️ lefthook install: Skip bun because it could not be found." | ||
echo "⚠️ lefthook install: This may be due to the fact that the mise installation has not been completed." | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lefthook
のインストールセクションも同様に追加されており、PRの目的に適合しています。ただし、エラーメッセージには誤りがあり、「Skip bun」とありますが、これは明らかにコピペのミスでしょう。正しいツール名に修正する必要があります。
- echo "⚠️ lefthook install: Skip bun because it could not be found."
+ echo "⚠️ lefthook install: Skip lefthook because it could not be found."
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
############################################################################## | |
## | |
## lefthook | |
## | |
############################################################################## | |
echo "" | |
echo "🚀 lefthook install: Start" | |
if type lefthook >/dev/null 2>&1; then | |
if lefthook install; then | |
echo "✅ lefthook install: Success" | |
else | |
echo "🚫 lefthook install: Failed" | |
fi | |
else | |
echo "⚠️ lefthook install: Skip bun because it could not be found." | |
echo "⚠️ lefthook install: This may be due to the fact that the mise installation has not been completed." | |
fi | |
############################################################################## | |
## | |
## lefthook | |
## | |
############################################################################## | |
echo "" | |
echo "🚀 lefthook install: Start" | |
if type lefthook >/dev/null 2>&1; then | |
if lefthook install; then | |
echo "✅ lefthook install: Success" | |
else | |
echo "🚫 lefthook install: Failed" | |
fi | |
else | |
echo "⚠️ lefthook install: Skip lefthook because it could not be found." | |
echo "⚠️ lefthook install: This may be due to the fact that the mise installation has not been completed." | |
fi |
############################################################################## | ||
## | ||
## bun | ||
## | ||
############################################################################## | ||
echo "" | ||
echo "🚀 bun install: Start" | ||
if type bun >/dev/null 2>&1; then | ||
if bun install; then | ||
echo "✅ bun install: Success" | ||
else | ||
echo "🚫 bun install: Failed" | ||
fi | ||
else | ||
echo "⚠️ bun install: Skip bun because it could not be found." | ||
echo "⚠️ bun install: This may be due to the fact that the mise installation has not been completed." | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bun
のインストールを処理するセクションの追加は、PRの目的に沿っています。ただし、エラーメッセージの文言が少し不正確です。例えば、「mise installation has not been completed」というメッセージが表示されますが、このスクリプトは mise
のインストール状況を直接確認していません。より正確なエラーメッセージを提供することをお勧めします。
- echo "⚠️ bun install: This may be due to the fact that the mise installation has not been completed."
+ echo "⚠️ bun install: bunが見つかりません。インストールが必要かもしれません。"
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
############################################################################## | |
## | |
## bun | |
## | |
############################################################################## | |
echo "" | |
echo "🚀 bun install: Start" | |
if type bun >/dev/null 2>&1; then | |
if bun install; then | |
echo "✅ bun install: Success" | |
else | |
echo "🚫 bun install: Failed" | |
fi | |
else | |
echo "⚠️ bun install: Skip bun because it could not be found." | |
echo "⚠️ bun install: This may be due to the fact that the mise installation has not been completed." | |
fi | |
############################################################################## | |
## | |
## bun | |
## | |
############################################################################## | |
echo "" | |
echo "🚀 bun install: Start" | |
if type bun >/dev/null 2>&1; then | |
if bun install; then | |
echo "✅ bun install: Success" | |
else | |
echo "🚫 bun install: Failed" | |
fi | |
else | |
echo "⚠️ bun install: Skip bun because it could not be found." | |
echo "⚠️ bun install: bunが見つかりません。インストールが必要かもしれません。" |
Visit the preview URL for this PR (updated for commit 25e3d3e): https://asis-quest-catalog-dev--pr434-improve-gh-433-himwljso.web.app (expires Thu, 27 Jun 2024 12:34:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 5aa3b98f0f68e3358ab4b28a7b45d288ba01e139 |
Issue
概要
bun を追加します。
レビュー観点
レビューレベル
レビュー優先度
参考リンク
スクリーンショット
Summary by CodeRabbit
新機能
commitlint.config.cjs
ファイルを追加しました。lefthook.yml
ファイルを追加しました。更新
.tool-versions
ファイルでbun
とruby
のバージョンを変更しました。package.json
にプロジェクトのメタデータおよびスクリプトを追加しました。bootstrap.sh
スクリプトを更新し、bun
とlefthook
のインストールチェックを追加しました。メンテナンス
.gitignore
ファイルにnode_modules
を追加しました。