New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace event-stream by through2 #57
Conversation
b4111aa
to
e1fe7bb
Compare
Thanks for your PR!
|
Hey sorry for the delay, I misread some stuff in through2, so yeah, |
Thanks! Works fine! |
package.json
Outdated
@@ -26,7 +26,8 @@ | |||
"minimist": "^1.1.1", | |||
"nightwatch": "^1.0.6", | |||
"plugin-error": "^1.0.1", | |||
"shell-quote": "^1.4.3" | |||
"shell-quote": "^1.4.3", | |||
"through2": "^3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
through2
-> through
?
In addition, I think that event-stream
package is no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True! I'll did that a bit in a hurry, sorry for that.
I'll update the package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@louis-bompart Thanks! |
event-stream, one of the dependencies of the package, have been backdoored (see dominictarr/event-stream#115).
To avoid potential issues, I would recommend using a smaller package that does just what's needed, like
through
or, as proposed in this PRthrough2
. Both are imho valid choices, I just chosethrough2
because it has a higher download count on npm and its latest update is more recent.