Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow phpunit 10 #55

Merged
merged 3 commits into from Jan 16, 2024
Merged

Conversation

Chris53897
Copy link
Contributor

PhpUnit 10 needs a trait to use prophesize()
PHPUnit\Framework\TestCase::prophesize() is deprecated and will be removed in PHPUnit 10. Please use the trait provided by phpspec/prophecy-phpunit.

This needs to be merged to get PhpUnit 10 installed and working.
phpspec/prophecy-phpunit#45

@tattali
Copy link
Owner

tattali commented Feb 7, 2023

Hi ! Have you experienced errors with this pull request?

@Chris53897
Copy link
Contributor Author

Hi. No, i removed the deprecations in phpunit 9. So i hope everything is fine.
But V. 10 will not get installed at the moment, so i can not confirm that it works.
After prophecy-phpunit supports phpunit 10, i will test and remove the draft status.

@Chris53897
Copy link
Contributor Author

prophecy-phpunit support for phpunit 10 will probably released shortly.
I can finish this PR after that

@Chris53897 Chris53897 marked this pull request as ready for review December 8, 2023 15:51
@Chris53897
Copy link
Contributor Author

Well, i was wrong with the 'shortly' release ;(
But it is released today. https://github.com/phpspec/prophecy-phpunit/releases/tag/v2.1.0

@tattali
PR is now ready to review

@tattali tattali merged commit 0885fc7 into tattali:master Jan 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants