Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/php8 perf #58

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Feature/php8 perf #58

merged 2 commits into from
Jul 1, 2023

Conversation

Chris53897
Copy link
Contributor

Superseeds #57
With a possible solution for #46

Add a additional paramter if the event should be unique.
https://github.com/tattali/CalendarBundle/compare/master...Chris53897:feature/php8-perf?expand=1#diff-e29df28b700bc5afb6adaf9697c4489ddb60b252021b353e5d078af1f9e73a9eR44

Tests:
https://github.com/tattali/CalendarBundle/compare/master...Chris53897:feature/php8-perf?expand=1#diff-176744ef8dbdd61a7010c8f3dcb08b6e4647e4dfb8d9276f764c1c6131c9c41cR46

This is a BC Break if the default Value is false.
But maybe this is new major anyways.

For isset or array_key_exists an unique-Field like id has to be mandatory.
But this is a BC Break as well.

@tattali
Copy link
Owner

tattali commented Apr 20, 2023

Hi, can you rebase from master and show only changes of this pull request.
Thanks!

@Chris53897
Copy link
Contributor Author

@tattali I merged master into this. (more on accident, but almost the same effect if you squash and merge buton it github.

@tattali tattali merged commit 2943469 into tattali:master Jul 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants