Skip to content

Commit

Permalink
fix some problems defined it pull request comments
Browse files Browse the repository at this point in the history
  • Loading branch information
tatterdemalion committed Apr 20, 2016
1 parent 7aad2ec commit 2ec744f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,12 @@ Lets say we have a model called ``Fruit``:

class Fruit(TranslationModel):
name = CharField(max_length=255)
translatable_fields = ['name']

def __str__(self):
return self.name
class Meta:
translatable_fields = ('name',)

``TranslationModel`` adds a jsonb field to this table and sets
translations in a notation like the one below:
Expand Down
4 changes: 2 additions & 2 deletions nece/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from distutils.version import StrictVersion
from django import get_version
from django.db import models
import django.db.models.options as options
from django.db.models import options
from nece.managers import TranslationManager, TranslationMixin
from nece.exceptions import NonTranslatableFieldError

Expand All @@ -13,7 +13,7 @@
else:
from nece.fields.pgjson import JSONField

options.DEFAULT_NAMES = options.DEFAULT_NAMES + ('translatable_fields',)
options.DEFAULT_NAMES += ('translatable_fields',)


class TranslationModel(models.Model, TranslationMixin):
Expand Down
2 changes: 1 addition & 1 deletion tests/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class Fruit(TranslationModel):
scientific_name = models.CharField(max_length=255)

class Meta:
translatable_fields = ['name', 'benefits']
translatable_fields = ('name', 'benefits', )

def __str__(self):
return self.name

0 comments on commit 2ec744f

Please sign in to comment.