Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON admin editor #35

Merged
merged 5 commits into from
Aug 5, 2019
Merged

JSON admin editor #35

merged 5 commits into from
Aug 5, 2019

Conversation

k0t3n
Copy link
Contributor

@k0t3n k0t3n commented Jul 30, 2019 •
edited

Use the django-admin-json-editor library to display JSON easy-to-read/edit format.

  • Create TranslatableModelAdmin
  • Add auto-generated scheme
  • Fix docs

@coveralls
Copy link

coveralls commented Jul 30, 2019 •
edited

Coverage Status

Coverage decreased (-5.5%) to 93.401% when pulling 926e068 on k0t3n:json-admin-editor into d6ed117 on tatterdemalion:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-6.0%) to 92.929% when pulling c28e165 on k0t3n:json-admin-editor into d6ed117 on tatterdemalion:master.

@k0t3n k0t3n changed the title WIP: JSON admin editor JSON admin editor Jul 30, 2019
@k0t3n k0t3n mentioned this pull request Jul 30, 2019
Open
@tatterdemalion
Copy link
Owner

Great job! I figured out that 'django_admin_json_editor' should be in INSTALLED_APPS in order for this to work correctly. Otherwise we get a template error on admin detail page.

@k0t3n
Copy link
Contributor Author

k0t3n commented Jul 31, 2019

Great job! I figured out that 'django_admin_json_editor' should be in INSTALLED_APPS in order for this to work correctly. Otherwise we get a template error on admin detail page.

Yep, my fault. Let me fix the docs.

@k0t3n
Copy link
Contributor Author

k0t3n commented Aug 4, 2019

@tatterdemalion already looks good

@tatterdemalion tatterdemalion merged commit 9542623 into tatterdemalion:master Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatterdemalion tatterdemalion tatterdemalion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k0t3n @coveralls @tatterdemalion