New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dockerize #13
Conversation
Can we create
All env vars have to be prefixed by Not all things you have changed to getQuestion does make sense f.e.: MNEMONIC in storeWallet ... it is not configuration and shouldn't be read from env vars. |
testing github actions fixing github action fixes to dockerize action fix docker tags fix docker tags
Dockerfile
Outdated
|
||
# Install supporting libraries | ||
|
||
RUN apt-get install -y libusb-1.0-0-dev usbutils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be nice to have apt-get
commands in one RUN
statement as recommended by dockerfile best practices:
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run
It helps keeping the image minimal and clean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can modify the Dockerfile if you want.
|
||
WORKDIR /usr/src/app | ||
|
||
RUN apt-get update && apt-get install -y libusb-1.0-0-dev usbutils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to bother again... As mentioned in the best practices it's advised to finish the line with && rm -rf /var/lib/apt/lists/*
to clean up the apt lists downloaded by apt-get update
.
ca47c58
to
6bffcf6
Compare
.github/workflows/dockerize.yml
Outdated
run: docker login -u $DOCKER_USER -p $DOCKER_PASSWORD | ||
|
||
- name: build image | ||
run: docker build . --file Dockerfile -t ${{secrets.DOCKER_USER}}/tatum-kms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to have 2 tags - latest and from the package.json
a51cc6a
to
c99cef8
Compare
c99cef8
to
6a86197
Compare
No description provided.