-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useful guide to start the project locally #4
Comments
I didn't think about that, I just assumed people would use this as a leiningen dependency. Perhaps we should have some sort of quick start guide in the gh pages and possibly the README. Another thing that could be useful is an examples folder with a couple of simple projects, like an example e2e test and some screen scraping example. |
I whipped up a quick screen scraping example project while figuring out how to get started with this library, but to be honest, it's practically identical to Still, if you want the PR, just let me know. A couple of unrelated things I noticed while working on the example project:
|
I don't think we need the example, if it's same as the test we currently have. But I'll gladly take a PR to remove the vestigial println and add URI/URL support for |
Makes sense. Maybe the README could point to the unit tests, though? I certainly found them very useful.
OK, I'll see if I can take a look. Should the |
I added a note about chrome_test to README. I'm closing this issue. |
Thanks for a great library:
I have one suggestion that might be useful for someone to get started with the project:
The text was updated successfully, but these errors were encountered: