You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @samyfodil , I would like to contribute to it and I have created a reusable Retry method. Is it too complex? Maybe I can simplify and only have it specific for deployment key. And for reading maxRetries & waitBeforeRetry how can we read from global variable os.GetEnv() || default or keep it in Monkey struct? Can you please guide me?
I have created a draft PR.
Sometimes, a build might be triggered before the repository is registered, which mean a deployment key was added. For these reason we have a retry logic here https://github.com/taubyte/tau/blob/main/protocols/monkey/job.go#L88. Frankly, this code does not look good.
I suggest moving the check for deployment key to https://github.com/taubyte/tau/blob/main/protocols/monkey/job.go#L41, and use a helper function that will retry for a number of times till we get repo with a deployment key.
The text was updated successfully, but these errors were encountered: