Implement transparent slider ticks (repeats) #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noor made me do it
naoei
approved these changes
Apr 23, 2022
naoei
reviewed
Apr 23, 2022
| @@ -75,6 +75,8 @@ public DrawableSlider(Slider obj) | |||
| slidingSample = new PausableSkinnableSound { Looping = true } | |||
| }); | |||
|
|
|||
| path.Ticks = repeatContainer; | |||
There was a problem hiding this comment.
This is probably a nitpick but, I'm not sure if we'd want to go with this name, as it may be confused with actual slider "ticks" (non-repeats).
naoei
reviewed
Apr 23, 2022
| protected override void LoadComplete() | ||
| { | ||
| base.LoadComplete(); | ||
| DrawableBox.Size = Vector2.Multiply(DrawableBox.Size, 0.75f); | ||
| AddInternal(InnerDrawableBox = new Container |
There was a problem hiding this comment.
Why aren't we overriding DrawableBox here?
There was a problem hiding this comment.
We need both the box and another inner box for rendering. The slider path uses their draw quads to render the mask and the outline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the repeats sometimes not appearing. For some reason the slider repeats weren't reset to their initial position after applying a hit object.