fix(cli/node): fix invoking the node cli from a shim, closes #193 (#207)

tauri-apps · Oct 4, 2022 · 09c0ed6 · 09c0ed6
1 parent 0b09cc1
commit 09c0ed6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changes/cli-node.md b/.changes/cli-node.md
@@ -0,0 +1,5 @@
+---
+"create-tauri-app-js": "patch"
+---
+
+Fix crash when nodejs binary has the version in its name, for example `node18`
diff --git a/packages/cli/node/create-tauri-app.js b/packages/cli/node/create-tauri-app.js
@@ -16,7 +16,7 @@ let binName;
 
 // Even if started by a package manager, the binary will be NodeJS.
 // Some distribution still use "nodejs" as the binary name.
-if (binStem === "node" || binStem === "nodejs") {
+if (binStem.match(/(nodejs|node)([1-9]*)*$/g)) {
   const managerStem = process.env.npm_execpath
     ? path.parse(process.env.npm_execpath).name.toLowerCase()
     : null;