Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite #61

Closed
wants to merge 16 commits into from
Closed

refactor: rewrite #61

wants to merge 16 commits into from

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jun 4, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Motivation

Our previous approach required us to maintain compatibility with other bootstrapping tools and how to invoke them with different package managers. We also couldn't integrate tauri in the final recipe and couldn't show an example of using tauri APIs.

Value

Pros

This approach allows for better control over the template and so we make sure to integrate tauri correctly and smoothly for users. It is also fast to bootstrap than before.

Cons

we have to keep the templates version up to date and maybe publish a new version every now and then just to bump version.

Approach

  • Recipes are now just called templates
  • A template is just a template-{name} directory that contains all the files
  • The template should be tailored towards tauri (eg configuring vite.config.jsandtauri.conf.json`) and includes an example of a tauri rust command.
  • Optionally the template should customize the icons to be a tauri logo combined with the framework logo.

@socket-security
Copy link

Socket Security Report

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
bufferutil@4.0.6 (added) binding.gyp package.json via vitest@0.13.1, jsdom@19.0.0, ws@8.8.0
utf-8-validate@5.0.9 (added) binding.gyp package.json via vitest@0.13.1, jsdom@19.0.0, ws@8.8.0
svelte-preprocess@4.10.7 (added) postinstall template-svelte-ts/package.json
bufferutil@4.0.6 (added) install package.json via vitest@0.13.1, jsdom@19.0.0, ws@8.8.0
utf-8-validate@5.0.9 (added) install package.json via vitest@0.13.1, jsdom@19.0.0, ws@8.8.0
esbuild@0.14.46 (added) postinstall package.json via vitest@0.13.1, vite@2.9.12,template-react/package.json via vite@2.9.12,template-react-ts/package.json via vite@2.9.12,template-solid/package.json via vite@2.9.12,template-solid-ts/package.json via vite@2.9.12,template-svelte/package.json via vite@2.9.12,template-svelte-ts/package.json via vite@2.9.12,template-vue/package.json via vite@2.9.12,template-vue-ts/package.json via vite@2.9.12
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Package Location
bufferutil@4.0.6 (added) package.json via vitest@0.13.1, jsdom@19.0.0, ws@8.8.0
utf-8-validate@5.0.9 (added) package.json via vitest@0.13.1, jsdom@19.0.0, ws@8.8.0
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 6 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ⚠️ 2 new native modules detected

Powered by socket.dev

@amrbashir amrbashir mentioned this pull request Jun 19, 2022
13 tasks
@amrbashir
Copy link
Member Author

Closing in favor of rust rewrite in #77

@amrbashir amrbashir closed this Jun 25, 2022
@amrbashir amrbashir deleted the rewrite branch June 25, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant