Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sponsored" Plugin PRs #42

Closed
lorenzolewis opened this issue Sep 8, 2023 · 11 comments
Closed

"Sponsored" Plugin PRs #42

lorenzolewis opened this issue Sep 8, 2023 · 11 comments
Labels
domain: development Relates to the Development domain domain: governance Relates to the Governance & Guidance domain

Comments

@lorenzolewis
Copy link
Member

We currently have two pending plugin PRs that are done in collaboration with CrabNebula and Impierce Technologies:

The particular parts to bring attention to are here:

These areas render out into the respective READMEs like so:
Screenshot 2023-09-08 at 11 09 05

While we have approved CrabNebula as a sponsor inline with our current precedent (pending CrabNebula's thumbs-up for release), we have not had similar conversations for Impierce Technologies (although this is not to say we aren't open to those conversations).

To the point on current precedent, we have currently only highlighted "Sponsors" via our website:

Screenshot 2023-09-08 at 11 11 07

@Beanow outlined a few open questions in his comment on the barcode scanner PR that I'll attempt to summarize here:

  • To @lucasfernog: Have both CrabNebula and Impierce Technologies given the thumbs-up on this?
  • Was there a discussion in Tauri around how the logos would be placed and formatted?
  • What would a different company have to do to get the same treatment of getting their plugin adopted by @tauri-apps as an "official" plugin with sponsor callouts and everything?
  • Who is responsible for future maintenance, etc. of the plugin?

To echo what I believe is @Beanow 's sentiment, I don't personally want to hold these PRs up with this conversation. However I would recommend getting a gut-check from a non-CrabNebula board member on this as it's our first time in this area.

I would also like to have a larger discussion as mentioned before about how we define a Sponsor and opening up opportunities for a "Partner"-type relationship between Tauri and other entities. With that in mind I would like to reserve the right to modify the README in those respective PRs pending that conversation and any impacts that may have.

Lastly, while this is a fantastic opportunity to grow Tauri's functionality and I would love to see more collaborations like this in the future, I would like to be VERY mindful of development capacity to maintain not only these two plugins, but also any further plugins that could come up in the future. One potential option (that these two plugins may or may not fall into) would be to highlight any "community" plugins on a page such as https://beta.tauri.app/2/guide/list/#community-resources. This ensures we give visibility to the plugins but also allows Tauri to not necessarily take on maintenance of them if the organization as a whole deems that we don't have the capacity or interest to do so.


The current ask is:

  1. Could a non-CrabNebula board member please weight in on if the current state of the PRs linked above would be appropriate to merge into the Tauri codebase
  2. What future conversations (if any) do we need to discuss in order to more properly define this type of arrangement in hopes of similar opportunities coming up in the future?
@lucasfernog
Copy link
Member

The plugins were developed under a sponsorship collaboration between CN and Impierce Technologies. Basically we made a deal that made it possible to give back those plugins to the community instead of having them closed source. I should've started this discussion before opening that PR, sorry about that. I feel I should've also used my CN account to push that PR to make it clearer.

I like the idea of moving the scanner plugin to a community maintained workspace repository as it's a more specific use case, though the deep link plugin is definitely vital for Tauri core.

@lorenzolewis
Copy link
Member Author

Thanks @lucasfernog 💜 Are there any details on future expectations for maintenance that could be shared to give a bit more context?

@lucasfernog
Copy link
Member

The deep link plugin is one of the most requested Tauri features, so I feel it should be maintained by Tauri. As far as I know only this first iteration was sponsored.
As the scanner plugin is more specific, either we move it to a community repository or mark it as feature complete, that's the way I see it. Any other insight @nothingismagick ?

@Beanow Beanow added domain: development Relates to the Development domain domain: governance Relates to the Governance & Guidance domain labels Sep 9, 2023
@Beanow
Copy link
Member

Beanow commented Sep 13, 2023

Hey @jbolda @wravery @zackarychapple sorry to urge you but there is urgency 😆

Repeating from Lorenzo:

  1. Could a non-CrabNebula board member please weight in on if the current state of the PRs linked above would be appropriate to merge into the Tauri codebase.
  2. What future conversations (if any) do we need to discuss in order to more properly define this type of arrangement in hopes of similar opportunities coming up in the future?

Especially 1. is a blocker right now, so I would love to hear from at least one person a clear cut:
Can we proceed? / Do we request changes?

@wravery
Copy link

wravery commented Sep 13, 2023

I like what they're doing with this contribution, and I think we should figure out how to encourage this without creating a confusing precedent. Plus, the plugins themselves seem very useful and valuable to the community.

Perhaps "sponsored" is the wrong term, since it sounds like we expect to own maintaining them. Sponsorship implies ongoing support to me, this is more like a one time donation. How about acknowledging them as "contributed by," instead?

Maybe instead of or in addition to the note in the README which ends up embedded in the project repo, how about making a blog post highlighting the new functionality and thanking the contributors for their generosity? That way they get a PR boost and recognition without the implication of ongoing support, and the organization doesn't establish a tricky sponsorship backdoor.

@Beanow
Copy link
Member

Beanow commented Sep 13, 2023

Thank you @wravery!

@nothingismagick @lucasfernog does that look like a suitable alternative that can be adopted as-is?
Emphasis on the latter, because if we're all happy with that, it seems like the quickest path forward.

(Please ping additional decision makers for me if I'm skipping anyone.)

@lucasfernog
Copy link
Member

I love this idea, I think it's a good compromise for Tauri and "sponsors".

@jbolda
Copy link
Member

jbolda commented Sep 13, 2023

Great idea @wravery 🎉 It feels to be the best compromise to me!

@lucasfernog
Copy link
Member

@Beanow
Copy link
Member

Beanow commented Sep 14, 2023

Repeating for extra visibility:
tauri-apps/plugins-workspace#536 (comment)
tauri-apps/plugins-workspace#536 (comment)

Replies from https://github.com/JelleMillenaar CEO of Impierce Technologies.

@Beanow
Copy link
Member

Beanow commented Sep 14, 2023

I think we've resolved the questions. To summarize:

Have both CrabNebula and Impierce Technologies given the thumbs-up on this?

Was there a discussion in Tauri around how the logos would be placed and formatted?

What would a different company have to do to get the same treatment of getting their plugin adopted by @tauri-apps as an "official" plugin with sponsor callouts and everything?

  • The excellent 🚀 suggestion to use "contributed by" I think helps to make this more accessible in the future.
  • Though there is room to think about and clarify contributions and sponsorships generally.
    I think that can be for a later discussion though and I think isn't a blocker here.

Who is responsible for future maintenance, etc. of the plugin?

Could a non-CrabNebula board member please weight in on if the current state of the PRs linked above would be appropriate to merge into the Tauri codebase

What future conversations (if any) do we need to discuss in order to more properly define this type of arrangement in hopes of similar opportunities coming up in the future?


The open points I think fit best in an overall sponsorships / contributions discussion.
So with that I'll close this issue as resolved! 💯
Thanks all for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: development Relates to the Development domain domain: governance Relates to the Governance & Guidance domain
Projects
None yet
Development

No branches or pull requests

5 participants