Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux): do not close window on CloseRequested event #114

Merged
merged 2 commits into from
Jul 5, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner June 30, 2021 17:37
@lucasfernog lucasfernog requested a review from a team June 30, 2021 17:37
@lucasfernog
Copy link
Member Author

Seems like we need something else since the delete event is also fired when calling close explicitly.

@lucasfernog lucasfernog marked this pull request as draft June 30, 2021 17:54
@lucasfernog
Copy link
Member Author

A little weird that it fires the CloseRequested event twice but it still works. I don't think there's an alternative on GTK.

@lemarier
Copy link
Member

lemarier commented Jun 30, 2021

A little weird that it fires the CloseRequested event twice

@lucasfernog Want me to take a look before merging?

@lucasfernog
Copy link
Member Author

Sure @lemarier

@lucasfernog
Copy link
Member Author

Looks good now, I just had to force window destroy on wry since it keeps a Rc so the drop isn't called sometimes.

@lucasfernog lucasfernog merged commit ea7330e into dev Jul 5, 2021
@lucasfernog lucasfernog deleted the fix/linux-close-requested branch July 5, 2021 23:14
@github-actions github-actions bot mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants