fix: #268 - Add API for MacOS NSWindow::isDocumentEdited() #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
reviewed
Jan 17, 2022
|
Thanks for contribution. It seems the PR you linked, just got merged, I guess we need to wait for release only. |
joshchngs
force-pushed
the
macos-document-edited
branch
from
c65d01d
to
2b50be3
Compare
|
Done. I'm not clear on the difference between |
amrbashir
requested changes
Jan 18, 2022
This fixes tauri-apps#268 and therefore tauri-apps/tauri#3125 The setter API is added upstream in the cocoa crate (servo/core-foundation-rs PR tauri-apps#493)
joshchngs
force-pushed
the
macos-document-edited
branch
from
2b50be3
to
1ff2ec0
Compare
amrbashir
added
status: waiting
|
This PR needs to wait for a new release of |
amrbashir
requested changes
Sep 30, 2022
src/platform_impl/macos/window.rs
Outdated
| unsafe { | ||
| self | ||
| .ns_window | ||
| .isDocumentEdited() |
There was a problem hiding this comment.
looks like a new version of cocoa won't be released anytime soon and we have been waiting for ages, can you just inline the objc call from this PR https://github.com/servo/core-foundation-rs/pull/493/files here
amrbashir
reviewed
Oct 3, 2022
amrbashir
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Add API for MacOS NSWindow::isDocumentEdited() This fixes #268 and therefore tauri-apps/tauri#3125 The setter API is added upstream in the cocoa crate (servo/core-foundation-rs PR #493) * use objc directly * fmt * cast to i8 * Update src/platform/macos.rs
Merged
|
lol the PR is so old, it was targeting |
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This fixes #268 and therefore tauri-apps/tauri#3125
isDocumentEdited#268Does this PR introduce a breaking change?
Checklist
fix #___, #___)Other information
The setter API is added upstream in the cocoa crate (servo/core-foundation-rs PR #493)), which will need to be merged & released before this PR.