Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macos): fire LoopDestroyed when the dock's Quit item is clicked #351

Merged
merged 1 commit into from Mar 28, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team March 26, 2022 18:20
@lucasfernog lucasfernog requested a review from a team as a code owner March 26, 2022 18:20
@lucasfernog
Copy link
Member Author

This allows Tauri to perform cleanup code when the macOS dock Quit is clicked. Currently the process just exits, and the event loop is not notified.

@wusyong wusyong merged commit 34257a7 into dev Mar 28, 2022
@wusyong wusyong deleted the feat/dock-quit branch March 28, 2022 06:58
@github-actions github-actions bot mentioned this pull request Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants