Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linux): implement Window::set_cursor_position #373

Merged
merged 3 commits into from Apr 23, 2022
Merged

feat(linux): implement Window::set_cursor_position #373

merged 3 commits into from Apr 23, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team April 23, 2022 00:12
@amrbashir amrbashir changed the title feat(linux): implement window.set_cursor_position() feat(linux): implement Window::set_cursor_position Apr 23, 2022
@amrbashir amrbashir force-pushed the feat/linux/set-cursor-position branch from a04b99a to 36b278e Compare April 23, 2022 00:15
@amrbashir amrbashir mentioned this pull request Apr 23, 2022
Closed
@amrbashir
Copy link
Member Author

I don't even know if this works (don't have access to a PC rn), so test and confirm before merge.

@lucasfernog
Copy link
Member

Don't tell me you're developing on your Android phone like that dude 😂

@lucasfernog
Copy link
Member

Aaaaaaaaaaaaaaaaaaaaaaaaaaaand it works! You're the best mobile developer in the world!

@amrbashir amrbashir requested a review from a team as a code owner April 23, 2022 00:39
@lucasfernog lucasfernog merged commit afffaea into dev Apr 23, 2022
@lucasfernog lucasfernog deleted the feat/linux/set-cursor-position branch April 23, 2022 00:42
@amrbashir
Copy link
Member Author

Don't tell me you're developing on your Android phone like that dude

termux and neovim magic 😉

Anyways, thanks for the quick test and for the kind words.

@github-actions github-actions bot mentioned this pull request Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @lucasfernog