Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window can't be hidden when maximized #384

Merged
merged 5 commits into from
Jun 15, 2022
Merged

Fix window can't be hidden when maximized #384

merged 5 commits into from
Jun 15, 2022

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented May 7, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@wusyong wusyong requested a review from a team May 7, 2022 04:42
@wusyong wusyong requested a review from a team as a code owner May 7, 2022 04:42
@amrbashir
Copy link
Member

amrbashir commented May 7, 2022 •
edited

Handling WindowFlags::MAXIMIZED before WindowFlags::VISIBLE will bring back an old bug where maximizing a hidden window will also show it. Any call to ShowWindow should be after handling WindowFlags::VISIBLE

@wusyong
Copy link
Member Author

wusyong commented May 7, 2022

How about I check it on MAXIMIZED flag diff instead?

@amrbashir
Copy link
Member

It works but it has a bug:

  1. maximize
  2. hide
  3. show
  4. unmaximize -> the window doesn't return to its former size

amrbashir and others added 2 commits June 13, 2022 17:39
@amrbashir @lucasfernog
Update src/platform_impl/windows/window_state.rs
a5083fd 
Co-authored-by: Lucas Fernandes Nogueira <lucas@tauri.studio>
@amrbashir
Revert "Update src/platform_impl/windows/window_state.rs"
e206195 
This reverts commit a5083fd.
@wusyong
Copy link
Member Author

wusyong commented Jun 14, 2022

The update is working for me. @lucasfernog could you also check again?

@lucasfernog
Copy link
Member

I can confirm this is working now.

@wusyong wusyong merged commit cd9ad33 into dev Jun 15, 2022
@wusyong wusyong deleted the flag branch June 15, 2022 06:54
@github-actions github-actions bot mentioned this pull request Jun 15, 2022
Merged
@rming rming mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wusyong @amrbashir @lucasfernog