Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix drag drop on Windows #401

Merged
merged 2 commits into from
May 23, 2022
Merged

Fix drag drop on Windows #401

merged 2 commits into from
May 23, 2022

Conversation

wravery
Copy link
Contributor

@wravery wravery commented May 23, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This is the equivalent change to tauri-apps/wry@fa64a27, discovered after #400 was already merged. I reviewed all of the Windows-specific uses of Vec<>::with_capacity, and it looks like this is the only spot where it then passes the buffer as a slice instead of a pointer.

@wravery wravery requested a review from a team May 23, 2022 19:08
@wravery wravery requested a review from a team as a code owner May 23, 2022 19:08
@wravery wravery changed the title Fix drag drop Fix drag drop on Windows May 23, 2022
@lucasfernog lucasfernog merged commit d0dbfa1 into tauri-apps:dev May 23, 2022
@github-actions github-actions bot mentioned this pull request May 23, 2022
@wravery wravery deleted the fix-drag-drop branch May 23, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants