Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macos): add SystemTray::set_tooltip , ref #409 #410

Merged
merged 10 commits into from
Aug 2, 2022

Conversation

pevers
Copy link
Contributor

@pevers pevers commented May 29, 2022

What kind of change does this PR introduce?

This implements the set_tool_tip method on a tray. I understand that this will probably not be merged before the v1 release. Please let me know if I can continue to work on this to also support the other platforms or if you would rather wait.

Screenshot 2022-05-29 at 18 15 10

This should close #409

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@pevers pevers changed the title feat: add set_tool_tip to traym, close #409 feat: add set_tool_tip to tray, close #409 Jun 2, 2022
@pevers
Copy link
Contributor Author

pevers commented Jun 14, 2022

Hi, sorry to bother @wusyong , is it ok to continue work on this?

@amrbashir
Copy link
Member

amrbashir commented Jul 7, 2022

@pevers sorry for the delay. It would be perfect if you can finish Linux and Windows implementation but if you don't want too I can merge this and add them later.

@pevers pevers marked this pull request as ready for review July 19, 2022 16:47
@pevers pevers requested a review from a team as a code owner July 19, 2022 16:47
@pevers
Copy link
Contributor Author

pevers commented Jul 19, 2022

@pevers sorry for the delay. It would be perfect if you can finish other Linux and Windows implementation but if you don't want too I can merge this and add them later.

Thanks for your reply @amrbashir ! I currently don't have access to my Windows machine, so I updated this PR and I can create an issue for the Windows and Linux implementation if that is OK?

@amrbashir
Copy link
Member

It is fine, I will add them in this PR tomorrow or later today.

@amrbashir
Copy link
Member

Sorry for the delay, I totally forgot I was going to implement other platforms.

It seems Linux's libappindicator doesn't support setting tooltips so I refactored the PR a bit for future Windows implementation because I can't do it right now.

@amrbashir amrbashir changed the title feat: add set_tool_tip to tray, close #409 feat: add set_tool_tip to tray, ref #409 Aug 2, 2022
@amrbashir amrbashir changed the title feat: add set_tool_tip to tray, ref #409 feat(macos): add SystemTray::set_tooltip , ref #409 Aug 2, 2022
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@amrbashir amrbashir merged commit 14e2656 into tauri-apps:dev Aug 2, 2022
@github-actions github-actions bot mentioned this pull request Aug 2, 2022
@pevers pevers deleted the feat/set-tool-tip-tray branch August 4, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] tray add set_tool_tip method
2 participants