Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: emit resize event on frame_did_change on macOS, closes #436 #439

Merged
merged 3 commits into from
Jun 22, 2022
Merged

fix: emit resize event on frame_did_change on macOS, closes #436 #439

merged 3 commits into from
Jun 22, 2022

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jun 22, 2022 •
edited

When the window switches mode from normal to tabbed one, it doesn't
get resized, however the frame gets resized. This commit makes
winit to track resizes when frame changes instead of window.

Co-authored-by: Phillip Hellewell sshock@users.noreply.github.com

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@wusyong wusyong requested a review from a team as a code owner June 22, 2022 06:16
Yu-Wei Wu and others added 2 commits June 22, 2022 14:23
@sshock
On macOS, emit resize event on frame_did_change
b09a5a7 
When the window switches mode from normal to tabbed one, it doesn't
get resized, however the frame gets resized. This commit makes
winit to track resizes when frame changes instead of window.

Co-authored-by: Phillip Hellewell <sshock@users.noreply.github.com>
Add change file
ace72d1
@wusyong wusyong merged commit 54062ca into dev Jun 22, 2022
@wusyong wusyong deleted the frame_did_change branch June 22, 2022 10:59
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Merged
@lucasfernog lucasfernog mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wusyong @amrbashir