Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linux) add with_temp_icon_dir builder extension #452

Merged
merged 7 commits into from
Jun 26, 2022

Conversation

Beanow
Copy link
Member

@Beanow Beanow commented Jun 26, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This is the replacement approach for #450.
Rather than detecting Flatpaks with Tao, we'll allow setting a temp_icon_dir to override default behavior.

Note, some refactoring was involved so I've made several commits for easier review.

Also as this adds a new (non breaking) feature, I assumed this is a minor version increment.

Testing:

  • The unit test is updated.
    1. Run with cargo test --features=tray.
  • The example is updated.
    1. Run with cargo run --features=tray --example=system_tray.
    2. Verify that the example created an icon at path /tmp/tao-examples/*.png

@Beanow Beanow requested a review from a team as a code owner June 26, 2022 17:24
Rather than rust analyzer
@amrbashir amrbashir merged commit ce209d3 into tauri-apps:dev Jun 26, 2022
@github-actions github-actions bot mentioned this pull request Jun 26, 2022
@Beanow Beanow deleted the feat/configure-tmp-dir branch June 26, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants