fix: maximizing window on linux, closes #442

[keiya01]

What kind of change does this PR introduce?

• Bugfix
• Feature
• Docs
• New Binding issue #___
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Does this PR introduce a breaking change?

• Yes, and the changes were approved in issue #___
• No

Checklist

• When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
• A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
• I have added a convincing reason for adding this feature, if necessary

Other information

[amrbashir]

Just tried this PR and the bug still exists

Here is my repro:

// Copyright 2019-2021 Tauri Programme within The Commons Conservancy
// SPDX-License-Identifier: Apache-2.0

use tao::{
  event::{Event, WindowEvent},
  event_loop::{ControlFlow, EventLoop},
  window::WindowBuilder,
};

#[allow(clippy::single_match)]
fn main() {
  let event_loop = EventLoop::new();

  let mut window = Some(
    WindowBuilder::new()
      .with_title("A fantastic window!")
      .with_inner_size(tao::dpi::LogicalSize::new(1080, 1980))
      .with_maximized(true)
      .with_resizable(false)
      .build(&event_loop)
      .unwrap(),
  );

  event_loop.run(move |event, _, control_flow| {
    *control_flow = ControlFlow::Wait;
    println!("{:?}", event);

    match event {
      Event::WindowEvent {
        event: WindowEvent::CloseRequested,
        window_id: _,
        ..
      } => {
        // drop the window to fire the `Destroyed` event
        window = None;
      }
      Event::WindowEvent {
        event: WindowEvent::Destroyed,
        window_id: _,
        ..
      } => {
        *control_flow = ControlFlow::Exit;
      }
      Event::MainEventsCleared => {
        if let Some(w) = &window {
          w.request_redraw();
        }
      }
      _ => (),
    }
  });
}
```

[keiya01]

@amrbashir
I fixed the above error. Please check the following commit 🙇
c326771

[amrbashir]

the last commit brought more issues than it solved. If you you set the size to 100,200 and set resizable to false and maximized to true, it will fill the whole screen which it shouldn't.

Here is some scenarios with the expected outcome to help you debug this further:

•   {
    	"width": 100,
    	"height": 200,
    	"resizable": true,
    	"maximized": true,
    }

  the window should open maximized but when you unmaximize it, it should restore its size to 100, 200 and the window can be resized using the mouse

•   {
    	"width": 100,
    	"height": 200,
    	"resizable": false,
    	"maximized": true,
    }

  the window should open maximized but when you unmaximize it, it should restore its size to 100, 200 and the window can NOT be resized using the mouse

•   {
    	"width": 100,
    	"height": 200,
    	"resizable": true,
    	"maximized": false,
    }

  the window should NOT open maximized and its size should be 100, 200 and can be resized using the mouse

•   {
    	"width": 100,
    	"height": 200,
    	"resizable": false,
    	"maximized": false,
    }

  the window should NOT open maximized and its size should be 100, 200 and can NOT be resized using the mouse

[keiya01]

@amrbashir
Thank you for your help 🙏

If you you set the size to 100,200 and set resizable to false and maximized to true, it will fill the whole screen which it shouldn't.

Please tell me about the above sentence.
I think my latest commit is filling window with resizable: false and maximized: true, but shouldn't we fill window in this senario?

[keiya01]

And I forgot to fix maximization in runtime, so I will fix it...

[amrbashir]

I think my latest commit is filling window with resizable: false and maximized: true, but shouldn't we fill window in this senario?

My bad I mixed them up. While I was testing, I had resizable true and maximized false and it maximized the window which it shouldn't.

just try to match the 4 scenarios I posted above with the expected outcome while creating the window and in runtime.

[keiya01]

My bad I mixed them up. While I was testing, I had resizable true and maximized false and it maximized the window which it shouldn't.

In my environment, when I had resizable true and maximized false, the window is not maximized.
Is this case occurred in runtime?

[amrbashir]

No, it was when creating the window. I'll do more testing tomorrow.

[amrbashir]

I did some more testing and noted down the issues I found below but I am not sure if these are bugs or the desired behavior.

maximized	resizable
true	true	works perfectly
false	true	works perfectly
true	false	can't be UNmaximized at runtime
false	false	can't be maximized at runtime

[keiya01]

Thank you for your investigation. Yeah I'm fixing runtime behavior.
And I think maximized true and resizable false senario should work but I will check if this senario works on other platform.

[keiya01]

I tested these cases on macOS and windows.
On macOS these are working great but on windows these are not working...
But I think maximized: true, resizable: false should work because this is easy to understand intuitively.

[amrbashir]

I think this PR is good enough but will let @wusyong decide whether he want to merge or not

[keiya01]

Do we need to support maximizing window on windows at initialization?
If you agree, I will fix it in another PR.