Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed inner_size even if resizable is set to false, closes #302 #461

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix: fixed inner_size even if resizable is set to false, closes #302 #461

merged 1 commit into from
Jul 5, 2022

Conversation

keiya01
Copy link
Member

@keiya01 keiya01 commented Jul 4, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@keiya01 keiya01 requested a review from a team as a code owner July 4, 2022 05:33
@keiya01 keiya01 self-assigned this Jul 4, 2022
@keiya01 keiya01 force-pushed the fix/inner-size-non-resizable-linux branch from e79cc8c to 608815f Compare July 4, 2022 05:45
@wusyong wusyong merged commit 17203d0 into dev Jul 5, 2022
@wusyong wusyong deleted the fix/inner-size-non-resizable-linux branch July 5, 2022 04:39
@github-actions github-actions bot mentioned this pull request Jul 5, 2022
Merged
@keiya01 keiya01 mentioned this pull request Jul 5, 2022
Closed
@github-actions github-actions bot mentioned this pull request Jul 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees

@keiya01 keiya01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keiya01 @wusyong