Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window::is_minimized() #486

Merged
merged 4 commits into from
Aug 6, 2022
Merged

Window::is_minimized() #486

merged 4 commits into from
Aug 6, 2022

Conversation

henry40408
Copy link
Member

@henry40408 henry40408 commented Jul 19, 2022 •
edited

closes #257

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

N/A

@henry40408 henry40408 force-pushed the feature/issue-257 branch 9 times, most recently from b1fff9e to bdc96d4 Compare August 4, 2022 14:25
@henry40408 henry40408 changed the title window.is_minimized() Window::is_minimized() Aug 4, 2022
@henry40408 henry40408 marked this pull request as ready for review August 4, 2022 14:43
@henry40408 henry40408 requested a review from a team as a code owner August 4, 2022 14:43
amrbashir
amrbashir requested changes Aug 4, 2022
View reviewed changes
examples/window_debug.rs Outdated Show resolved Hide resolved
examples/window_debug.rs Outdated Show resolved Hide resolved
src/platform_impl/macos/mod.rs Outdated Show resolved Hide resolved
henry40408 and others added 2 commits August 4, 2022 22:51
@henry40408 @amrbashir
Apply suggestions from code review
547a7dd 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@henry40408
refactor(macos): move methods to Window
e3a0a8d 
- Window::is_maximized
- Window::is_minimized
amrbashir
amrbashir requested changes Aug 6, 2022
View reviewed changes
src/platform_impl/macos/mod.rs Outdated Show resolved Hide resolved
@amrbashir amrbashir merged commit 9c34815 into tauri-apps:dev Aug 6, 2022
@amrbashir
Copy link
Member

Thank you

@github-actions github-actions bot mentioned this pull request Aug 6, 2022
Merged
@henry40408 henry40408 deleted the feature/issue-257 branch August 6, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: window.is_minimized()
2 participants
@henry40408 @amrbashir