Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tray): remove from tray on Drop on macOS #520

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner August 4, 2022 16:23
@lucasfernog
Copy link
Member Author

I also wanted this on Linux but couldn't find an API :( though we can hide it.

@amrbashir
Copy link
Member

Yeah last time I checked, I couldn't find one either. It seems that the linux community has given up on appindicator.

@lucasfernog
Copy link
Member Author

I'll PR hiding it - better than nothing lol

@amrbashir
Copy link
Member

Agreed

@amrbashir amrbashir merged commit aca4d3f into dev Aug 4, 2022
@amrbashir amrbashir deleted the feat/macos-tray-drop branch August 4, 2022 16:37
@github-actions github-actions bot mentioned this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants