Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linux/globalShortcut): grab the shortcut with extra mods, closes #307 #540

Merged
merged 1 commit into from
Aug 20, 2022
Merged

fix(linux/globalShortcut): grab the shortcut with extra mods, closes #307 #540

merged 1 commit into from
Aug 20, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner August 20, 2022 14:13
@amrbashir amrbashir mentioned this pull request Aug 20, 2022
Closed
@wusyong wusyong merged commit 7e5556e into dev Aug 20, 2022
@wusyong wusyong deleted the fix-x11-global-shortcuts-for-good-cause-i-am-done-with-this-shit branch August 20, 2022 16:58
@github-actions github-actions bot mentioned this pull request Aug 20, 2022
Merged
@github-actions github-actions bot mentioned this pull request Aug 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrbashir @wusyong