Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linux/globalShortcut): disable on wayland #543

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

ralf1307
Copy link
Contributor

@ralf1307 ralf1307 commented Aug 26, 2022

Don't start the global shortcut thread on wayland, as its highly x11
specific and otherwise results in a segfault in libX11.

Disabling the thread allows for example Cinny to start with the envvar DISPLAY unset and GDK_BACKEND=wayland.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@ralf1307 ralf1307 requested a review from a team as a code owner August 26, 2022 17:35
@amrbashir
Copy link
Member

can you also add a change file in .changes? take a look at .changes/README.md if you don't know how.

@ralf1307
Copy link
Contributor Author

ralf1307 commented Aug 26, 2022

A change file should be added now

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ralf1307
Copy link
Contributor Author

Running rustfmt as ci complains. This sadly makes the diff harder to read.

@amrbashir
Copy link
Member

It is fine but looks like you're commits are not signed, and I won't be able to merge unless they are signed.

Don't start the global shortcut thread on wayland, as its highly x11
specific and otherwise results in a segfault in libX11.
@ralf1307
Copy link
Contributor Author

ralf1307 commented Aug 26, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants