Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menus): add app name to native Quit and Hide items, closes #536 #570

Merged
merged 7 commits into from
Sep 25, 2022
Merged

fix(menus): add app name to native Quit and Hide items, closes #536 #570

merged 7 commits into from
Sep 25, 2022

Conversation

caesar
Copy link
Contributor

@caesar caesar commented Sep 25, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Implemented by getting the name of the current app from NSRunningApplication and adding it to the menu items labels.

closes #536

@caesar caesar requested a review from a team as a code owner September 25, 2022 00:35
@caesar
Copy link
Contributor Author

caesar commented Sep 25, 2022

Sorry, forgot cargo fmt again… fixed now

amrbashir
amrbashir requested changes Sep 25, 2022
View reviewed changes
src/platform_impl/macos/menu.rs Outdated Show resolved Hide resolved
src/platform_impl/macos/menu.rs Outdated Show resolved Hide resolved
@caesar
Copy link
Contributor Author

caesar commented Sep 25, 2022

This feels to me like a much cleaner implementation now, thanks for the pointers @amrbashir.

Could you just confirm that you're happy with these changes to the app_name function?

@FabianLars
Copy link
Member

I think that the Option should be reintroduced. You can't really expect that CFBundleName is set in all scenarios

amrbashir
amrbashir requested changes Sep 25, 2022
View reviewed changes
src/platform_impl/macos/util/mod.rs Outdated Show resolved Hide resolved
src/platform_impl/macos/menu.rs Outdated Show resolved Hide resolved
.changes/macos-menus-appname.md Outdated Show resolved Hide resolved
.changes/macos-menus-appname.md Outdated Show resolved Hide resolved
amrbashir
amrbashir requested changes Sep 25, 2022
View reviewed changes
src/platform_impl/macos/util/mod.rs Show resolved Hide resolved
src/platform_impl/macos/menu.rs Outdated Show resolved Hide resolved
@caesar
Copy link
Contributor Author

caesar commented Sep 25, 2022

Thanks for all the reviews @amrbashir 🙂

amrbashir
amrbashir approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@amrbashir amrbashir merged commit 65f768e into tauri-apps:dev Sep 25, 2022
@github-actions github-actions bot mentioned this pull request Sep 25, 2022
Merged
@caesar caesar deleted the menus/appname branch September 25, 2022 19:31
@caesar caesar mentioned this pull request Sep 25, 2022
Closed
This was referenced Oct 5, 2022
Closed
Open
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quit and Hide native menu items should include app name
3 participants
@caesar @FabianLars @amrbashir