Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Inverse mouse scroll wheel on Linux #585

Merged
merged 3 commits into from
Oct 11, 2022
Merged

fix: Inverse mouse scroll wheel on Linux #585

merged 3 commits into from
Oct 11, 2022

Conversation

marc2332
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Winit implementation:

X11: https://github.com/rust-windowing/winit/blob/5d2aca90bd266f2ba02bf04ccab5fe6f2b830dc6/src/platform_impl/linux/x11/event_processor.rs#L812
Wayland: https://github.com/rust-windowing/winit/blob/9e6f666616341ddd76fc61c6a0ed8dcbf3392a28/src/platform_impl/linux/wayland/seat/pointer/handlers.rs#L224

@marc2332 marc2332 requested a review from a team as a code owner October 11, 2022 18:28
amrbashir
amrbashir requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a little nit-pick in the change file

.changes/linux-inversed-mouse-wheel.md Outdated Show resolved Hide resolved
@marc2332 @amrbashir
Update .changes/linux-inversed-mouse-wheel.md
f70eb6d 
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@amrbashir amrbashir merged commit 8451f75 into tauri-apps:dev Oct 11, 2022
@github-actions github-actions bot mentioned this pull request Oct 11, 2022
Merged
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marc2332 @amrbashir