Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): scale menu item icon height to 18, closes #584 #590

Merged
merged 3 commits into from
Oct 15, 2022

Conversation

grant0417
Copy link
Contributor

@grant0417 grant0417 commented Oct 15, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@grant0417 grant0417 requested a review from a team as a code owner October 15, 2022 02:20
@grant0417
Copy link
Contributor Author

Hey, @amrbashir I fixed the code you pushed, it worked but just needed the import and order changed on the function calls.

Thanks for all the help!

@amrbashir
Copy link
Member

thanks @grant0417 for taking it to the finish line.

@amrbashir amrbashir merged commit 5e3d344 into tauri-apps:dev Oct 15, 2022
@github-actions github-actions bot mentioned this pull request Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants