Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EventLoopExtMacOS::set_activate_ignoring_other_apps #612

Merged
merged 1 commit into from
Nov 1, 2022
Merged

feat: add EventLoopExtMacOS::set_activate_ignoring_other_apps #612

merged 1 commit into from
Nov 1, 2022

Conversation

grant0417
Copy link
Contributor

@grant0417 grant0417 commented Nov 1, 2022 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This adds the ability to modify the call to activateIgnoringOtherApps and set the argument to NO which was previously not possible

@grant0417 grant0417 changed the title feat: add EventLoopExtMacOS::set_activate_ignoring_other_apps feat: add EventLoopExtMacOS::set_activate_ignoring_other_apps Nov 1, 2022
@grant0417 grant0417 marked this pull request as ready for review November 1, 2022 19:19
@grant0417 grant0417 requested a review from a team as a code owner November 1, 2022 19:19
@grant0417
Copy link
Contributor Author

Looks like the test failed but it was unrelated to the code

amrbashir
amrbashir approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@amrbashir amrbashir merged commit d2c6a91 into tauri-apps:dev Nov 1, 2022
@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grant0417 @amrbashir