Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On macOS, call next responder in view's keyDown and doCommandbySelector #623

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Nov 14, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

fix tauri-apps/tauri#5592 (comment)

@wusyong wusyong requested a review from a team as a code owner November 14, 2022 07:16
@wusyong wusyong merged commit 045b768 into dev Nov 14, 2022
@wusyong wusyong deleted the acc branch November 14, 2022 14:49
@github-actions github-actions bot mentioned this pull request Nov 14, 2022
@wusyong
Copy link
Member Author

wusyong commented Nov 18, 2022

This caused the regression of beap sound again. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Accelerators with single character in CustomMenuItem won't work
2 participants