-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch android_fn! to a proc_macro #654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you should add doc on those macro if we want to expose this.
And also add tao-macro to workspace and our CI config
Or we could make this into separate repo and crate then. |
will do, I was just looking for a first review for the macro code.
I'd rather keep this in the repo. |
Alright! We keep int this repo then. I'm not concerned about the implementation since it's fairly short but I treat proc macro as a different DSL. A comprehensive documentation is required. |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
This is rewrite was due to happen soon and it allows us to:
_
in package name and escape it properly, instead of relying on users to pass it escaped.