Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch android_fn! to a proc_macro #654

Merged
merged 6 commits into from Dec 26, 2022
Merged

feat: switch android_fn! to a proc_macro #654

merged 6 commits into from Dec 26, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Dec 23, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This is rewrite was due to happen soon and it allows us to:

  1. handle _ in package name and escape it properly, instead of relying on users to pass it escaped.
  2. support variadic arguments to functions (encountered while implementing callback for when document.title is changed? wry#804)

@amrbashir amrbashir requested a review from a team as a code owner December 23, 2022 18:23
@wusyong wusyong self-assigned this Dec 24, 2022
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you should add doc on those macro if we want to expose this.
And also add tao-macro to workspace and our CI config

@wusyong
Copy link
Member

wusyong commented Dec 26, 2022

Or we could make this into separate repo and crate then.

@amrbashir
Copy link
Member Author

LGTM, but you should add doc on those macro if we want to expose this.
And also add tao-macro to workspace and our CI config

will do, I was just looking for a first review for the macro code.

Or we could make this into separate repo and crate then.

I'd rather keep this in the repo.

@amrbashir amrbashir requested a review from a team as a code owner December 26, 2022 12:52
@wusyong
Copy link
Member

wusyong commented Dec 26, 2022

I'd rather keep this in the repo.

Alright! We keep int this repo then. I'm not concerned about the implementation since it's fairly short but I treat proc macro as a different DSL. A comprehensive documentation is required.

@amrbashir amrbashir merged commit b3aa398 into dev Dec 26, 2022
@amrbashir amrbashir deleted the tao-macros branch December 26, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants