Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On iOS, add Sync trait on EventLoopProxy when T has Send trait #658

Merged
merged 1 commit into from
Jan 4, 2023
Merged

On iOS, add Sync trait on EventLoopProxy when T has Send trait #658

merged 1 commit into from
Jan 4, 2023

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jan 4, 2023 •
edited

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Close #656

@wusyong wusyong requested a review from a team as a code owner January 4, 2023 03:54
@wusyong wusyong merged commit 651137c into dev Jan 4, 2023
@wusyong wusyong deleted the ios-sync branch January 4, 2023 12:54
This was referenced Jan 4, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send + Sync is not implemented for iOS proxy
2 participants
@wusyong @amrbashir