Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On macOS, fix resize event emits before fullscreen actually exit #662

Merged
merged 1 commit into from
Jan 9, 2023
Merged

On macOS, fix resize event emits before fullscreen actually exit #662

merged 1 commit into from
Jan 9, 2023

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jan 8, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

Other information

@wusyong wusyong requested a review from a team as a code owner January 8, 2023 09:19
amrbashir
amrbashir approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but I am afraid winit team won't accept this solution or does this issue not exist in winit?

.changes/mac-fullscreen-resize.md Show resolved Hide resolved
@wusyong wusyong merged commit 3867e7b into dev Jan 9, 2023
@wusyong wusyong deleted the mac-fullscreen-resize branch January 9, 2023 12:34
This was referenced Jan 9, 2023
Merged
Merged
@wusyong wusyong mentioned this pull request May 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wusyong @amrbashir